Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GHContentSearchBuilder to allow a Fork type #1315

Merged
merged 10 commits into from
Nov 22, 2021

Conversation

sahansera
Copy link
Contributor

@sahansera sahansera commented Nov 21, 2021

Description

  • Introduce a new enum GHFork.
  • Refactor the existing code to use the new GHFork enum.
  • Add a new unit test to test GitHub code search including results of forks.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@sahansera sahansera changed the title Refactor search forks Refactor GHContentSearchBuilder to allow a Fork type Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #1315 (4828993) into main (3069134) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1315      +/-   ##
============================================
+ Coverage     77.92%   78.02%   +0.09%     
- Complexity     2016     2027      +11     
============================================
  Files           198      199       +1     
  Lines          6224     6243      +19     
  Branches        355      356       +1     
============================================
+ Hits           4850     4871      +21     
+ Misses         1164     1162       -2     
  Partials        210      210              
Impacted Files Coverage Δ
...ava/org/kohsuke/github/GHContentSearchBuilder.java 80.76% <100.00%> (+6.85%) ⬆️
src/main/java/org/kohsuke/github/GHFork.java 100.00% <100.00%> (ø)
.../org/kohsuke/github/GHRepositorySearchBuilder.java 81.57% <100.00%> (+2.63%) ⬆️
.../main/java/org/kohsuke/github/GHSearchBuilder.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3069134...4828993. Read the comment docs.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good change. Need adjustment maintain backward compatibility.

@bitwiseman bitwiseman merged commit 7df326e into hub4j:main Nov 22, 2021
@sahansera sahansera deleted the refactor-search-forks branch June 25, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants