Remove getPath() #116
Merged
Remove getPath() #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the path and providing an enterprise url for the apiUrl, the /api/v3 portion gets duplicated. Since they will be combined on line 231 of GitHub.java there is no point just grabbing the path. See janinko/ghprb#178, and https://issues.jenkins-ci.org/browse/JENKINS-24145?focusedCommentId=208270#comment-208270
|
Kohsuke Kawaguchi » github-api #215 SUCCESS |
|
@suryagaddipati I know you guys JUST did a release 1 hour before this PR came in.... but any chance this can be reviewed and merged in? |
|
👍 |
1 similar comment
|
👍 |
|
|
|
👍 |
1 similar comment
|
+1 |
|
I haven't tested this code and was wondering, will this work, or what is the appropriate method to call to convert the url to a string |
|
👍 |
|
😃 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the path and providing an enterprise url for the apiUrl, the /api/v3 portion gets duplicated. Since they will be combined on line 231 of GitHub.java there is no point just grabbing the path. See janinko/ghprb#178, and https://issues.jenkins-ci.org/browse/JENKINS-24145?focusedCommentId=208270#comment-208270