Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing pull request using Github API return FileNotFoundException #34

Closed
mdelapenya opened this issue Apr 23, 2013 · 2 comments
Closed

Closing pull request using Github API return FileNotFoundException #34

mdelapenya opened this issue Apr 23, 2013 · 2 comments

Comments

@mdelapenya
Copy link

Using ghprb plugin, we have discovered that closing pull request is not working:

SEVERE: Couldn't close the pullrequest #10582: '
java.io.FileNotFoundException: https://api.github.com/repos/USER/REPO/issues/10582

As Github API says, pull requests must be accesed in this way:

GET /repos/:owner/:repo/pulls/:number

Using pulls intead of issues.
mdelapenya added a commit to mdelapenya/github-api that referenced this issue Apr 23, 2013
@mdelapenya
hub4j#34 use avi v3 API, getting pulls using 'pulls' instead of 'issues'
ac1edc0
kohsuke added a commit that referenced this issue Apr 23, 2013
@kohsuke
[FIXED issue #34] API route for pull requests uses 'pulls'
beec605
@kohsuke
Copy link
Collaborator

kohsuke commented Apr 23, 2013

I think this change would break the GHIssue class.

I claim my fix in beec605 does this properly. Please verify.

@kohsuke kohsuke closed this as completed Apr 23, 2013
@kohsuke kohsuke mentioned this issue Apr 23, 2013
Closed
@mdelapenya
Copy link
Author

Thanks for your quick answer!

I hope this fix will be released soon :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsuke @mdelapenya