You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: If there are more than 300 files in the commit diff, the response will include pagination link headers for the remaining files, up to a limit of 3000 files. Each page contains the static commit information, and the only changes are to the file listing.
Except hub4j doesn't support pagination at this time:
Use GHCommit.getFiles() on a commit with more than 300 files changed.
Expected behavior
Suggest deprecating getFiles() and adding a listFile() that returns a PagedIterable. However, I think that PagedIterable will need to be backed by a custom class similar to GHWorkflowsIterable with the GHCommit as the container. It's going to take some trial-and-error to figure out how this works.
The text was updated successfully, but these errors were encountered:
Describe the bug
https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#get-a-commit
Except
hub4j
doesn't support pagination at this time:github-api/src/main/java/org/kohsuke/github/GHCommit.java
Lines 418 to 421 in 9801b86
To Reproduce
Steps to reproduce the behavior:
GHCommit.getFiles()
on a commit with more than 300 files changed.Expected behavior
Suggest deprecating
getFiles()
and adding alistFile()
that returns aPagedIterable
. However, I think thatPagedIterable
will need to be backed by a custom class similar toGHWorkflowsIterable
with theGHCommit
as the container. It's going to take some trial-and-error to figure out how this works.The text was updated successfully, but these errors were encountered: