Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP parsing (second attempt) #489

Closed
wants to merge 4 commits into from

Conversation

fxposter
Copy link

@fxposter fxposter commented Jul 6, 2018

Basically this is a #433 PR, but rebased against current master with 2 changed lines related to
error handling (http-parser returns a boolean for an indication of a failure, while http_parser.rb actually threw exception there), so that now all tests pass.

ixti and others added 4 commits July 6, 2018 12:49
@ixti
Copy link
Member

ixti commented Jul 7, 2018

Awesome! Thanks!

I'll take care of this.

@ixti ixti self-requested a review July 7, 2018 10:15
@ixti ixti self-assigned this Jul 7, 2018
@tarcieri
Copy link
Member

This seems simple enough. @ixti mind taking another look?

@cognita
Copy link

cognita commented Jan 9, 2019

Will this be merged in the near future?
Could we provide any kind of support to make progress on this?

@ixti
Copy link
Member

ixti commented Jan 9, 2019

Yeah. Sorry had a pretty tough fourth quarter of 2018. Things are finally getting back in norm, so will work on this shortly. Plan is to merge this PR almost as is - with 3rd party dependency and declare HTTP::Parser as private API, and then when I will have time on thinking of good API we will make it public and slowly migrate to own FFI binding.

@ixti ixti mentioned this pull request Jan 14, 2019
@ixti ixti closed this in f1db84f Jan 14, 2019
ixti added a commit that referenced this pull request Jan 14, 2019
@ixti ixti mentioned this pull request Feb 25, 2019
ixti added a commit that referenced this pull request Oct 21, 2019
ixti added a commit that referenced this pull request Oct 21, 2019
ixti added a commit that referenced this pull request Oct 22, 2019
dentarg added a commit to dentarg/http that referenced this pull request Jan 13, 2020
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 7, 2020
Update ruby-http to 4.4.1.


## 4.4.1 (2020-03-29)

* Backport [#590](httprb/http#590)
  Fix parser failing on some edge cases.
  ([@ixti])

## 4.4.0 (2020-03-25)

* Backport [#587](httprb/http#587)
  Fix redirections when server responds with multiple Location headers.
  ([@ixti])

* Backport [#599](httprb/http#599)
  Allow passing HTTP::FormData::{Multipart,UrlEncoded} object directly.
  ([@ixti])

## 4.3.0 (2020-01-09)

* Backport [#581](httprb/http#581)
  Add Ruby-2.7 compatibility.
  ([@ixti], [@janko])


## 4.2.0 (2019-10-22)

* Backport [#489](httprb/http#489)
  Fix HTTP parser.
  ([@ixti], [@fxposter])


## 4.1.1 (2019-03-12)

* Add `HTTP::Headers::ACCEPT_ENCODING` constant.
  ([@ixti])


## 4.1.0 (2019-03-11)

* [#533](httprb/http#533)
  Add URI normalizer feature that allows to swap default URI normalizer.
  ([@mamoonraja])


## 4.0.5 (2019-02-15)

* Backport [#532](httprb/http#532) from master.
  Fix pipes support in request bodies.
  ([@ixti])


## 4.0.4 (2019-02-12)

* Backport [#506](httprb/http#506) from master.
  Skip auto-deflate when there is no body.
  ([@Bonias])


## 4.0.3 (2019-01-18)

* Fix missing URL in response wrapped by auto inflate.
  ([@ixti])

* Provide `HTTP::Request#inspect` method for debugging purposes.
  ([@ixti])


## 4.0.2 (2019-01-15)

* [#506](httprb/http#506)
  Fix instrumentation feature.
  ([@paul])


## 4.0.1 (2019-01-14)

* [#515](httprb/http#515)
  Fix `#build_request` and `#request` to respect default options.
  ([@RickCSong])


## 4.0.0 (2018-10-15)

* [#482](httprb/http#482)
  [#499](httprb/http#499)
  Introduce new features injection API with 2 new feaures: instrumentation
  (compatible with ActiveSupport::Notification) and logging.
  ([@paul])

* [#473](httprb/http#473)
  Handle early responses.
  ([@janko-m])

* [#468](httprb/http#468)
  Rewind `HTTP::Request::Body#source` once `#each` is complete.
  ([@ixti])

* [#467](httprb/http#467)
  Drop Ruby 2.2 support.
  ([@ixti])

* [#436](httprb/http#436)
  Raise ConnectionError when writing to socket fails.
  ([@janko-m])

* [#438](httprb/http#438)
  Expose `HTTP::Request::Body#source`.
  ([@janko-m])

* [#446](httprb/http#446)
  Simplify setting a timeout.
  ([@mikegee])

* [#451](httprb/http#451)
  Reduce memory usage when reading response body.
  ([@janko-m])

* [#458](httprb/http#458)
  Extract HTTP::Client#build_request method.
  ([@tycoon])

* [#462](httprb/http#462)
  Fix HTTP::Request#headline to allow two leading slashes in path.
  ([@scarfacedeb])

* [#454](httprb/http#454)
  [#464](httprb/http#464)
  [#384](httprb/http#384)
  Fix #readpartial not respecting max length argument.
  ([@janko-m], [@marshall-lee])
@tarcieri tarcieri mentioned this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants