Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ConnectionError when writing to socket fails #436

Merged

Commits on Oct 14, 2017

  1. Raise ConnectionError when writing to socket fails

    Writing to the TCP socket can also fail with various exceptions, just
    like when opening or reading from it. For example, it happened to me
    that an Errno::EPIPE exceptions was raised during file upload,
    presumably because the server closed the connection early.
    
    In order to be consistent with re-raising low-level exceptions as
    HTTP::ConnectionError when opening or reading from the TCP socket,
    we also add the same behaviour when writing to the socket.
    janko committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    ea8117e View commit details
    Browse the repository at this point in the history