Add scalafix integration #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jun 3, 2022
Comment on lines
+79
to
+85
| lazy val scalafixSettings: Seq[Setting[_]] = | ||
| Seq( | ||
| scalafixDependencies ++= Seq( | ||
| "org.http4s" %% "http4s-scalafix-internal" % "0.23.12", | ||
| "com.github.liancheng" %% "organize-imports" % "0.6.0" | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Weird or no?
Actually I think we can upstream many/all of the internal rules to typelevel-scalafix. They seem widely applicable.
There was a problem hiding this comment.
"Upstream to Typelevel unless it's HTTP" has been my mantra for many things. Seems applicable here, too.
rossabaker
approved these changes
Jun 4, 2022
Comment on lines
+79
to
+85
| lazy val scalafixSettings: Seq[Setting[_]] = | ||
| Seq( | ||
| scalafixDependencies ++= Seq( | ||
| "org.http4s" %% "http4s-scalafix-internal" % "0.23.12", | ||
| "com.github.liancheng" %% "organize-imports" % "0.6.0" | ||
| ) | ||
| ) |
There was a problem hiding this comment.
"Upstream to Typelevel unless it's HTTP" has been my mantra for many things. Seems applicable here, too.
|
Alrighty, let's ship this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.