Added HPySlice_New #481
Merged
Added HPySlice_New #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangerer
reviewed
Jun 6, 2024
There was a problem hiding this comment.
LGTM so far. As you mentioned, please add tests. This should be very easy since this function only fails if the object cannot be allocated and we don't test for out of memory problems.
You should just test if HPy_NULL is correctly handled if passed as start, stop, or step.
fangerer
reviewed
Jun 7, 2024
test/test_hpyslice.py
Outdated
| return HPy_NULL; | ||
| } | ||
| HPy length = HPySlice_New(ctx, start, stop, step); | ||
| return length; |
There was a problem hiding this comment.
minor: this could just be return HPySlice_New(...)
hpy/tools/autogen/public_api.h
Outdated
| * | ||
| * :param start: | ||
| * A pointer to a variable where to write the unpacked slice start. Must not | ||
| * be ``NULL``. |
There was a problem hiding this comment.
I guess this is just a copy-and-paste-error but those parameters are not pointers.
I would write something like: "A handle to an object to be used as slice start" or something (your English is better than mine 🙂). Also, we allow HPy_NULL !
(Same for the other params.)
fangerer
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HPySlice_New - still need to add tests. Needed for benchmarks for Cython.