Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci.yml: Upgrade some jobs to run on macos-latest #467

Closed
wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 27, 2023

Failures discussed at

Suppress with:
--> @pytest.mark.xfail(macos_version() > (12, ), reason="setup.py xxx is deprecated")

@cclauss cclauss changed the title ci.yml: macos-latest ci.yml: macos-latest fails Dec 27, 2023
@cclauss cclauss marked this pull request as draft December 30, 2023 15:22
@cclauss cclauss mentioned this pull request Dec 30, 2023
@cclauss cclauss marked this pull request as ready for review December 30, 2023 18:56
Copy link
Contributor

@fangerer fangerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort but I think this should not be merged as it is.
Using macos-latest is, ofc, fine and we should do that.
However, the current solution just passes tests because of the xfail annotations. This means, we are no longer running the marked tests because they all fail on macos-12 and if they break on macos-11, we won't notice.

Until I find the time to investigate and properly fix that, I would be fine if we add a CI job that runs just those tests on macos-11.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 11, 2024

All of this is a bit strange on GitHub Actions because the current macOS is v14.2 but given that GHA runs on Intel Macs, the highest version we can test on is 12.

UPDATE: macOS 14 on M1 is now available on GitHub Actions.

@cclauss cclauss requested a review from fangerer January 12, 2024 14:19
@cclauss
Copy link
Contributor Author

cclauss commented Jan 20, 2024

Did Add main_tests os: macos-11 on python-version: 3.12 do what you were requesting or did I misunderstand?

@cclauss cclauss marked this pull request as draft January 30, 2024 20:41
@cclauss cclauss changed the title ci.yml: macos-latest fails ci.yml: Upgrade some jobs to macos-latest Jan 30, 2024
@cclauss cclauss marked this pull request as ready for review January 30, 2024 21:56
@cclauss cclauss changed the title ci.yml: Upgrade some jobs to macos-latest ci.yml: Upgrade some jobs to run on macos-latest Jan 30, 2024
@cclauss
Copy link
Contributor Author

cclauss commented Apr 5, 2024

Over the next 12 weeks, jobs using the macos-latest runner label will migrate from macOS 12 (Monterey) to macOS 14 (Sonoma).

https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image

@cclauss cclauss closed this Apr 26, 2024
@cclauss cclauss deleted the patch-1 branch April 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants