This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
adds support for <@userId|username> syntax for mentions and direct_mentions #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related, other option for a way to do this in #210 fine with either way, just want to be able to get events on nickname mentions as well |
| @@ -416,6 +416,9 @@ function Slackbot(configuration) { | |||
|
|
|||
| slack_botkit.log('** Setting up custom handlers for processing Slack messages'); | |||
| slack_botkit.on('message_received', function(bot, message) { | |||
| var mentionSyntax = '<@' + bot.identity.id + '(\\|' + bot.identity.name + ')?>'; | |||
There was a problem hiding this comment.
Looks like usernames can contain ".", we'll need to escape those
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Slack, the RegExp for mentions and direct_mentions does not match if the message uses the valid <@userid|username> syntax. This PR updates the regex so that botkit will emit mention and direct_mention events if the username is included.
Note: usernames can only be in the set [a-z0-9] so there won't be any special characters that could cause problems constructing a regex including usernames. See https://get.slack.help/hc/en-us/articles/216360827-Changing-your-username