Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a simple facade for instantiating/using the web runtime #279

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Provide a simple facade for instantiating/using the web runtime #279

merged 2 commits into from
Aug 30, 2021

Conversation

Michael-F-Bryan
Copy link
Contributor

No description provided.

@Michael-F-Bryan Michael-F-Bryan added area - runtime The Rust Rune runtime category - intuitiveness Something which may be unintuitive to the user or affect ergonomics effort - easy This should be pretty simple labels Aug 28, 2021
@Michael-F-Bryan
Copy link
Contributor Author

@Ge-te, over the weekend @f0rodo and I had a look at how end users would use our API. I've introduced a builder type here which will automate a lot of the tricky stuff and removed a lot of complexity from the Runtime class.

Would you be able to review this PR and let me know what you think?

Ge-te
Ge-te approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@Ge-te Ge-te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, gonna test it asap

@Ge-te
Copy link
Contributor

Ge-te commented Aug 30, 2021 •
edited
Loading

I like the builder type, gonna solve a lot of things in the future

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review August 30, 2021 14:29
@Michael-F-Bryan Michael-F-Bryan merged commit 3b6e32c into master Aug 30, 2021
@Michael-F-Bryan Michael-F-Bryan deleted the web-runtime-builder-api branch August 30, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ge-te Ge-te Ge-te approved these changes

@f0rodo f0rodo Awaiting requested review from f0rodo

Assignees
No one assigned
Labels
area - runtime The Rust Rune runtime category - intuitiveness Something which may be unintuitive to the user or affect ergonomics effort - easy This should be pretty simple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-F-Bryan @Ge-te