Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #184

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Update examples #184

merged 4 commits into from
Jul 12, 2022

Conversation

vreynolds
Copy link
Contributor

@vreynolds vreynolds commented Jul 11, 2022

Which problem is this PR solving?

  • moving examples closer to the source of truth

Short description of the changes

@vreynolds vreynolds requested a review from a team July 11, 2022 22:19
@vreynolds vreynolds added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Jul 11, 2022
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running locally (go run .) works great! Running in docker though I get a 500 error in the browser. Error in Docker shows "Error connecting to database: dial tcp 172.24.0.2:3306: connect: connection refused", and so event sent to honeycomb is "sql: no rows in result set". Not sure yet what piece is missing for this, and/or if this is specific to my setup.

I also added a comment about updating the endpoint to api.honeycomb, and maybe using the local libhoney-go codepath instead of pulling a specific version from github.

examples/webapp/honeycomb_helpers.go Outdated Show resolved Hide resolved
examples/webapp/go.mod Show resolved Hide resolved
@vreynolds
Copy link
Contributor Author

@JamieDanielson the docker error with sql row missing is dues to the browser caching your session from "go run" - it's not the most robust app 😅 if you clear your cookies for localhost:8888, and re-run from docker, it should work 🤞

@JamieDanielson
Copy link
Contributor

@JamieDanielson the docker error with sql row missing is dues to the browser caching your session from "go run" - it's not the most robust app 😅 if you clear your cookies for localhost:8888, and re-run from docker, it should work 🤞

ah, facepalm. You are absolutely right:

libhoney-go_shout

@vreynolds vreynolds merged commit c9e7df0 into main Jul 12, 2022
@vreynolds vreynolds deleted the vera.update-examples branch July 12, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants