Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add os and arch to the meta.* data sent #200

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Commits on Jul 15, 2023

  1. Add os and arch to the meta.* data sent

    We live in a multiarch world now! I'm currently thinking about migrating
    a bunch of CI runners over from x86->arm64, and I can see a few uses for
    this in my buildevents data.
    
    1. What parts of my CI runs are on an x86 vs arm executor? What's been
    migrated, which spots are still to be done? (I expect this to be a
    gradual migration as various dependencies - mostly docker images -
    become available for arm.)
    
    2. Performance improvements - can we compare run time of one arch versus
    another?
    
    Both of these will be easily queried in buildevents data if these fields
    are present.
    
    Since this PR uses runtime.{GOOS,GOARCH}, I believe performance impact
    will be negligible - both of these are constants set by the golang
    runtime on startup, we're just using them.
    ismith committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    e696a45 View commit details
    Browse the repository at this point in the history