Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support E&S #146

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Support E&S #146

merged 6 commits into from
Apr 14, 2022

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Apr 14, 2022

Add new behavior in non-Classic environments, plus some cleanup. Closes #145.

  • Bump cobra to v1.4.0 - closes Bump github.com/spf13/cobra from 1.2.1 to 1.4.0 #143
  • Bump beeline to v1.8.0
  • Bump libhoney to v1.15.8
  • Use cobra.MatchAll instead of identical custom code.
  • Clean up buildURL function to construct URLs more safely.
  • The service_name field is mirrored to service.name.
  • Detect classic key and change behavior for non-classic mode:
    • Service Name, if specified, is used as the dataset as well as both service_name and service.name fields.
    • If dataset is specified and service name is not, it will be used but will generate a warning (except in quiet mode).
    • If both are specified, service name will be used, dataset is ignored, and a warning will be emitted (except in quiet mode).
    • The command name is now sent as command_name (in classic it is still sent as service_name).
    • The watch command now sets the name field to merely watch rather than a high-cardinality value, making it easier to aggregate queries across different builds.
    • The name of the dataset is trimmed of leading/trailing whitespace and a warning issued if the value was changed.

@kentquirk kentquirk requested a review from a team April 14, 2022 02:22
@MikeGoldsmith MikeGoldsmith added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Apr 14, 2022
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I've left a couple couple of suggestions 👍🏻

CHANGELOG.md Outdated Show resolved Hide resolved
cmd_root.go Outdated Show resolved Hide resolved
cmd_root.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @kentquirk 👍🏻

@kentquirk kentquirk merged commit 5a7ecab into main Apr 14, 2022
@kentquirk kentquirk deleted the kent.support_EandS_2 branch April 14, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for E&S
2 participants