Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display underlying error when verifying API key #135

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

jhchabran
Copy link
Contributor

@jhchabran jhchabran commented Jan 4, 2022

Which problem is this PR solving?

  • The error message Unable to create trace URL: unable to verify API key could be clearer. This PR prints the underlying error. Here how I came up to this:
    • I had misread the BUILDEVENT_APIKEY in the docs and actually used BUILDEVENT_API_KEY
    • I thus wrongly assumed there was some issue elsewhere because even re-reading the docs, the missing _ is hard to see (that's on me!)
    • I applied the patch in this PR to actually see what was the issue.
    • It showed me a message about the key being blank, so it finally clicked and I saw the missing _.

At this point, I thought I'd rather submit a PR just in case you find it appropriate :)

This (probably?) addresses #92.

Short description of the changes

  • It just prints the underlying error from libhoney when it cannot verify the API key.

@jhchabran jhchabran requested a review from a team January 4, 2022 19:00
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution @jhchabran 👍🏻

@MikeGoldsmith MikeGoldsmith merged commit ed862a0 into honeycombio:main Jan 7, 2022
@MikeGoldsmith MikeGoldsmith self-assigned this Jan 7, 2022
@MikeGoldsmith MikeGoldsmith added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants