Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FAQ, discuss getter topic #87

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Add FAQ, discuss getter topic #87

merged 2 commits into from
Apr 27, 2018

Conversation

ThomDietrich
Copy link
Collaborator

@ThomDietrich ThomDietrich commented Apr 26, 2018 •
edited
Loading

As discussed in #79

@timpur timpur self-requested a review April 26, 2018 09:56
@timpur
Copy link
Contributor

timpur commented Apr 26, 2018

Looks good.

marvinroger
marvinroger approved these changes Apr 27, 2018
View reviewed changes
Copy link
Member

@marvinroger marvinroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me! 👍

@ThomDietrich ThomDietrich merged commit fb8d153 into master Apr 27, 2018
@ThomDietrich ThomDietrich deleted the ThomDietrich-patch-1 branch April 27, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinroger marvinroger marvinroger approved these changes

@timpur timpur Awaiting requested review from timpur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomDietrich @timpur @marvinroger