Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dedicated namespace for private objs on Parameterized #766

Merged
merged 34 commits into from
Jul 11, 2023
Merged

Add a dedicated namespace for private objs on Parameterized #766

merged 34 commits into from
Jul 11, 2023

Commits on Jun 20, 2023

  1. first take at creating a private namespace

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    cd47f73 View commit details
    Browse the repository at this point in the history

  2. put initialized in the private namespace

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    314a492 View commit details
    Browse the repository at this point in the history

  3. remove unused property

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7f42e82 View commit details
    Browse the repository at this point in the history

  4. add slots to the private namespace

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    58a04b7 View commit details
    Browse the repository at this point in the history

  5. separate class and instance private objs

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e7adb2b View commit details
    Browse the repository at this point in the history

  6. rename variables

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0a2a54d View commit details
    Browse the repository at this point in the history

  7. more renaming

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    154afe6 View commit details
    Browse the repository at this point in the history

  8. rename

    @maximlt
    maximlt committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    fef3581 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge branch 'main' into private_namespace

    @maximlt
    maximlt committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a029770 View commit details
    Browse the repository at this point in the history

  2. foo

    @maximlt
    maximlt committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3588a16 View commit details
    Browse the repository at this point in the history

  3. store instance values in the private namespace

    @maximlt
    maximlt committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3c82039 View commit details
    Browse the repository at this point in the history

  4. store renamed on the class private namespace

    @maximlt
    maximlt committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    1d486ea View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. store the param dict in the private namespace

    @maximlt
    maximlt committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    f893950 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. simplify storing Parameters on a class

    @maximlt
    maximlt committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fec92aa View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Merge branch 'main' into private_namespace

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a0cfb3f View commit details
    Browse the repository at this point in the history

  2. simplify condition

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    cbbd20d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into private_namespace

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    c08d343 View commit details
    Browse the repository at this point in the history

  4. clean up comment

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0cd1fd1 View commit details
    Browse the repository at this point in the history

  5. update add_parameter test

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7247092 View commit details
    Browse the repository at this point in the history

  6. streamline and rename

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d5dee3b View commit details
    Browse the repository at this point in the history

  7. remove _internal_name Parameter slot

    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b107092 View commit details
    Browse the repository at this point in the history

  8. Revert "remove _internal_name Parameter slot" 

    This reverts commit b107092.
    @maximlt
    maximlt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    eb71b0e View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. restore _param_watchers

    @maximlt
    maximlt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    817c580 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into private_namespace

    @maximlt
    maximlt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    ce70eda View commit details
    Browse the repository at this point in the history

  3. add tests to check the namespace

    @maximlt
    maximlt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    6738ed6 View commit details
    Browse the repository at this point in the history

  4. handle Parameter access before super() is called

    @maximlt
    maximlt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    5265478 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Merge branch 'main' into private_namespace

    @maximlt
    maximlt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    fb06a68 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. replace internally _internal_name with name

    @maximlt
    maximlt committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    16bea93 View commit details
    Browse the repository at this point in the history

  2. update the docs

    @maximlt
    maximlt committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d263001 View commit details
    Browse the repository at this point in the history

  3. update docstrings and comments

    @maximlt
    maximlt committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    09b8403 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'main' into private_namespace

    @maximlt
    maximlt committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    beb6950 View commit details
    Browse the repository at this point in the history

  2. update the docs

    @maximlt
    maximlt committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    124fa53 View commit details
    Browse the repository at this point in the history

  3. update the tests

    @maximlt
    maximlt committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    df9470e View commit details
    Browse the repository at this point in the history

  4. fix the docs

    @maximlt
    maximlt committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    7cf4f86 View commit details
    Browse the repository at this point in the history