Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move environment variables into Pixi.toml #6251

Merged
merged 4 commits into from
May 30, 2024
Merged

Move environment variables into Pixi.toml #6251

merged 4 commits into from
May 30, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 27, 2024

It seems better to set the environment variables in pixi.toml so that the local run mimics CI more.

Also sneaking in some other changes:

  • Remove commented out dash
  • Move custom unfixable to unsafe fixes. The main point still stands: I don't want formatters to automatically remove unused variables and imports. Could set pre-commit to unsafe fixes at some point.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label May 27, 2024
hoxbro
hoxbro commented May 28, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@hoxbro hoxbro merged commit f39e0a0 into main May 30, 2024
14 checks passed
@hoxbro hoxbro deleted the update_pixi branch May 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoxbro @philippjfr