Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class variable not being used for vdims in RGB #5773

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 21, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #5773 (beef385) into main (68e87da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5773   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files         306      306           
  Lines       62767    62772    +5     
=======================================
+ Hits        55346    55351    +5     
  Misses       7421     7421           
Impacted Files Coverage Δ
holoviews/element/raster.py 78.92% <100.00%> (ø)
holoviews/tests/element/test_raster.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit be58b7e into main Jun 21, 2023
@hoxbro hoxbro deleted the fix_vdims_raster branch June 21, 2023 16:12
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ush that was a tricky one to hunt!

I'd be great if you could write up what you fixed/was wrong in the body of the PR. I'm just way too sad when I end up on such a PR in a git blame session.

holoviews/element/raster.py Show resolved Hide resolved
@hoxbro
Copy link
Member Author

hoxbro commented Jun 21, 2023

I'd be great if you could write up what you fixed/was wrong in the body of the PR. I'm just way too sad when I end up on such a PR in a git blame session.

My idea was to explain it in the comment + having a test for it. I will add a small description in the new PR.

I know this was pretty lazy of me, but I wanted it merged so I could continue to work on another issue (#5774).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants