Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Netty to 4.1.99.Final #590

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

wborn
Copy link
Contributor

@wborn wborn commented Aug 21, 2023

Description

This upgrades Netty to address:

It also fixes a bug when using JDK21+.

Related Issue

Closes #503

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created.
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@cla-bot
Copy link

cla-bot bot commented Aug 21, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wborn
Copy link
Contributor Author

wborn commented Aug 21, 2023

I can do the CLA if it is really neccessary for this one line change.
Let me know if you consider merging this PR, so I don't have to waste my time on the CLA. 😉

@cla-bot
Copy link

cla-bot bot commented Aug 30, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Sep 3, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wborn wborn changed the title Upgrade Netty to 4.1.96.Final Upgrade Netty to 4.1.97.Final Sep 3, 2023
@wborn
Copy link
Contributor Author

wborn commented Sep 3, 2023

The CLA is pending and I updated to 4.1.97.Final. 🚀

https://netty.io/news/2023/08/23/4-1-97-Final.html

@cla-bot
Copy link

cla-bot bot commented Sep 10, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Sep 23, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wborn wborn changed the title Upgrade Netty to 4.1.97.Final Upgrade Netty to 4.1.98.Final Sep 23, 2023
@wborn
Copy link
Contributor Author

wborn commented Sep 23, 2023

In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added.

I already did that weeks ago @cla-bot. 😉

@pglombardo
Copy link
Contributor

Hi @wborn - CLABot has some personality issues. :-)

Thanks for pointing this out. Just for this change that points out a new version number, the CLA isn't a blocker. I'll look to merge the change this week. Thanks again!

This addresses:

* CVE-2021-37136
* CVE-2021-37137
* CVE-2022-41915

It also fixes a bug when using JDK21+.
@cla-bot
Copy link

cla-bot bot commented Oct 1, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wborn on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@wborn wborn changed the title Upgrade Netty to 4.1.98.Final Upgrade Netty to 4.1.99.Final Oct 1, 2023
@wborn
Copy link
Contributor Author

wborn commented Oct 1, 2023

There's a 4.1.99.Final now that also fixes a bug on JDK21+:

https://netty.io/news/2023/09/21/4-1-99-Final.html

@pglombardo pglombardo merged commit 63e4e08 into hivemq:master Oct 3, 2023
1 check failed
@pglombardo
Copy link
Contributor

Thanks @wborn - I'll put out a new release soon!

@wborn wborn deleted the netty-4.1.96 branch October 3, 2023 08:20
@pglombardo
Copy link
Contributor

Release 1.3.3 is out!

@wborn
Copy link
Contributor Author

wborn commented Oct 3, 2023

Thanks a lot @pglombardo! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to io.netty:netty-codec-http:4.1.59.Final to solve vulnerability
2 participants