Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tls session resumption hostname verification #401

Merged
merged 12 commits into from
Apr 17, 2020
Merged

Feature/tls session resumption hostname verification #401

merged 12 commits into from
Apr 17, 2020

Conversation

SgtSilvio
Copy link
Member

@SgtSilvio SgtSilvio commented Apr 14, 2020 •
edited
Loading

Motivation
Resolves #201

Changes

  • Added https hostname verification, able to pass custom hostname verifier (Android compatible: https://developer.android.com/training/articles/security-ssl#WarningsSslSocket)
  • Enabled TLS session resumption by storing the SslContext
  • Added configurable timeouts: websocket handshake, proxy handshake, socket connect, mqtt connect
  • Numeric ip addresses are always resolved
  • Proxy address is resolved instead of server address
  • Removed proxy prefix from MqttProxyConfig getter and builder methods

@cla-bot cla-bot bot added the cla-signed label Apr 14, 2020
@SgtSilvio SgtSilvio requested review from gitseti and a user April 14, 2020 11:44
@SgtSilvio SgtSilvio self-assigned this Apr 14, 2020
@SgtSilvio SgtSilvio removed the request for review from RobinAtherton April 16, 2020 14:21
@SgtSilvio SgtSilvio merged commit fad7959 into develop Apr 17, 2020
@SgtSilvio SgtSilvio deleted the feature/tls-session-resumption-hostname-verification branch April 17, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LBrandl LBrandl LBrandl approved these changes

@gitseti gitseti Awaiting requested review from gitseti

Assignees

@SgtSilvio SgtSilvio

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS session resumption and hostname verification
2 participants
@SgtSilvio @LBrandl