Avoid topic filter stackoverflow & add topic tree compaction #338

SgtSilvio · 2019-10-17T14:07:20Z

Motivation
Resolves #334 (avoid any stack overflows possibly caused by many topic levels)

Changes

...com/hivemq/client/internal/mqtt/handler/publish/incoming/MqttIncomingPublishFlowsWithId.java

.../java/com/hivemq/client/internal/mqtt/handler/publish/incoming/MqttSubscriptionFlowTree.java

SgtSilvio added the improvement label Oct 17, 2019

SgtSilvio added this to the 1.1.3 milestone Oct 17, 2019

SgtSilvio self-assigned this Oct 17, 2019

cla-bot bot added the cla-signed label Oct 17, 2019

SgtSilvio changed the title ~~Bugfix/topic filter stackoverflow~~ Avoid topic filter stackoverflow & add topic tree compaction Oct 17, 2019

SgtSilvio force-pushed the bugfix/topic-filter-stackoverflow branch from dbf0d83 to eef1751 Compare October 25, 2019 21:45

SgtSilvio added 10 commits November 11, 2019 17:18

Avoid stack overflow in SubscriptionFlowTree

ac69593

Avoid stack overflow in SubscriptionFlowTree.findMatching

fe34938

Fixed MqttIncomingPublishFlowsWithId.findMatching

2d119aa

Avoid theoretical stack overflow in Ranges.returnId

b022827

Added topic tree compaction, improved TopicLevel(Iterator)

37b0ccd

Fixed topic tree compaction

2d79607

Added MqttSubscriptionFlowTreeTest.branching_compaction test

92bba63

Improved tests for MqttSubscriptionFlowTree

ee3062f

Added tests for TopicLevel, TopicLevels, TopicIterator

a0d585f

Small refactoring

9e191df

SgtSilvio force-pushed the bugfix/topic-filter-stackoverflow branch from eef1751 to 9e191df Compare November 11, 2019 21:19

SgtSilvio requested a review from gitseti November 13, 2019 07:32

gitseti approved these changes Nov 13, 2019

View reviewed changes

SgtSilvio merged commit 74f29c2 into develop Nov 13, 2019

SgtSilvio deleted the bugfix/topic-filter-stackoverflow branch November 13, 2019 20:23

Provide feedback