Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/allow-querystring-in-mqttwebsocketconfig #336

Merged
merged 3 commits into from
Oct 11, 2019
Merged

feature/allow-querystring-in-mqttwebsocketconfig #336

merged 3 commits into from
Oct 11, 2019

Conversation

alsanrum
Copy link
Contributor

@alsanrum alsanrum commented Oct 9, 2019 •
edited by SgtSilvio
Loading

Motivation
Allow querystring in MqttWebsocketConfig
Resolves #335

Changes
Add queryString in MqttWebSocketConfig.
Use queryString of the new MqttWeSocketConfig in URI inside of initChannel of MqttWebSocketInitializer class.

@cla-bot
Copy link

cla-bot bot commented Oct 9, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @alsanrum on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@alsanrum alsanrum changed the title Issue #335 feature/allow-querystring-in-mqttwebsocketconfig Oct 9, 2019
@cla-bot
Copy link

cla-bot bot commented Oct 9, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @alsanrum on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Oct 9, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @alsanrum on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@alsanrum alsanrum force-pushed the feature/allow-querystring-in-mqttwebsocketconfig branch from a5d99d3 to 3d139f2 Compare October 9, 2019 12:16
@cla-bot
Copy link

cla-bot bot commented Oct 9, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @alsanrum on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@SgtSilvio
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Oct 9, 2019

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2019
@SgtSilvio SgtSilvio added this to the 1.2 milestone Oct 9, 2019
@SgtSilvio
Copy link
Member

Resolves #335

@SgtSilvio SgtSilvio removed this from the 1.2 milestone Oct 9, 2019
SgtSilvio
SgtSilvio requested changes Oct 9, 2019
View reviewed changes
Copy link
Member

@SgtSilvio SgtSilvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and the nice PR.
The builder method has to be added to the interface.

@alsanrum alsanrum force-pushed the feature/allow-querystring-in-mqttwebsocketconfig branch from 3481773 to 8e0aa7b Compare October 9, 2019 17:21
@SgtSilvio SgtSilvio changed the base branch from develop to develop-1-2 October 11, 2019 20:44
@SgtSilvio
Copy link
Member

As this PR adds new APIs, it will be part of the next minor version 1.2.0.
So we can not merge this directly to develop yet, but instead to develop-1-2.
The feature can then already be used using a snapshot version develop-1-2-SNAPSHOT via JitPack: https://hivemq.github.io/hivemq-mqtt-client/docs/installation.html#snapshots

@SgtSilvio SgtSilvio merged commit 65a69c4 into hivemq:develop-1-2 Oct 11, 2019
@SgtSilvio SgtSilvio mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtSilvio SgtSilvio SgtSilvio approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alsanrum @SgtSilvio