Bugfix/issue #540 #568
Merged
Bugfix/issue #540 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated unlink function to use set for updating data holders in the list Signed-off-by: Gift Nnko <nnkogift@hotmail.com>
- Fixed issues with duplicate specificTargetsKey being incorrectly written - Implemented resetting of specificTargets to empty array when specific targets checkbox is unchecked - Changed default scorecard options key to options instead of scorecardOptions BREAKING CHANGE: - Change in options field may cause some inconsistencies in some scenarios, reconfiguration of options is advised Signed-off-by: Gift Nnko <nnkogift@hotmail.com>
- Fixed issues with clearing of specific targets when the specific targets checkbox is unchecked Signed-off-by: Gift Nnko <nnkogift@hotmail.com>
- Improved styling for data source configuration Signed-off-by: Gift Nnko <nnkogift@hotmail.com>
- Unset selected indicator when unlinking indicators Signed-off-by: Gift Nnko <nnkogift@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: - Change in options field may cause some inconsistencies in some scenarios, reconfiguration of options is advised
Fixes #540