Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the log messages #180

Closed
hildogjr opened this issue Feb 20, 2018 · 1 comment
Closed

Improve the log messages #180

hildogjr opened this issue Feb 20, 2018 · 1 comment
Assignees
@hildogjr
Labels
documentation Improvements need on documentation, used manual and log. enhancement Improvements on features already existent.

Comments

@hildogjr
Copy link
Owner

hildogjr commented Feb 20, 2018 •
edited
Loading

Improve the log messages to a better debug here by community / developers.
Use dist.label to print the distributors names.
Organize and standardize all messages, some distributors submodules have warning messages when not found quantity or part, others haven't this log message.
get_part_html_tree()of each submodule appear not use the dist parameter input. So remove this and change the log messages using the distributor names (not the variable dist).

Check the messages log in #174 to understand the point that have to be improved.
@hildogjr hildogjr added enhancement Improvements on features already existent. documentation Improvements need on documentation, used manual and log. labels Feb 20, 2018
hildogjr added a commit that referenced this issue Feb 24, 2018
@hildogjr
Merge pull request #181 from hildogjr/master
4eb0673 
 Something in #180 and #144
@hildogjr
Copy link
Owner Author

hildogjr commented Feb 24, 2018 •
edited
Loading

I did some to the kicost's modules layer and EDA submodule layers (still missing to all specific distributors submodules).
Use the fix on #161 and #146, and also the founded on farnell.py and newark.py #174 to improve that.

hildogjr added a commit that referenced this issue May 5, 2018
@hildogjr
Merge pull request #250 from hildogjr/master
db504e3 
#180 and imrpovements
hildogjr added a commit that referenced this issue May 5, 2018
@hildogjr
Merge pull request #251 from hildogjr/master
116cfac 
More #180
@hildogjr hildogjr self-assigned this Jul 4, 2018
@hildogjr hildogjr closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildogjr hildogjr

Labels
documentation Improvements need on documentation, used manual and log. enhancement Improvements on features already existent.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hildogjr