fix(init): fix hexo init error with a number target project name #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brelian
commented
May 21, 2020
| @@ -15,7 +15,7 @@ function initConsole(args) { | |||
| args = Object.assign({ install: true, clone: true }, args); | |||
|
|
|||
| const baseDir = this.base_dir; | |||
| const target = args._[0] ? resolve(baseDir, String(args._[0])) : baseDir; | |||
| const target = args._[0] ? resolve(baseDir, args._[0]) : baseDir; | |||
There was a problem hiding this comment.
Always parses it as a string. Manually convert is unnecessary anymore.
brelian
changed the title
SukkaW
approved these changes
May 25, 2020
5 tasks
SukkaW
added a commit
to SukkaW/hexo-cli
that referenced
this pull request
Jun 19, 2020
2 tasks
SukkaW
added a commit
that referenced
this pull request
Jun 19, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix
hexo initbug with a number target name. Also ref #45 #199 .Special notes for your reviewer:
/review
@SukkaW @tommy351