-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript: Omit Fetch Props from Component Props #242
Conversation
I was just writing up readme docs how to use the TypeScript types, and I realized the whole |
I just released this branch as beta |
Review was done in #230 (comment) |
This pulls in @yannick-cw's change from #230.
I first committed a small example in ab96a2a to repro the problem and then applied the fix in d5ae588.
@yannick-cw, @ddanielbee: Can you take a look at the
UserWidget
example and let me know if this is how you were using it, particularly how I definedFetchProps
andCompProps
and how I passed them in asconnect<FetchProps, CompProps>
. It compiles and all seems to work, but just wanted to make sure I got it correct as an example.Fixes #230