Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing crate READMEs and other cleanup #458

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jul 7, 2022

  • Adds READMEs for the libcnb-data and libcnb-proc-macros crates, since previously they were bundling the repo root README, which was confusing when looking at their crates.io listing (Use a separate README for libcnb-data and libcnb-proc-macros #274).
  • Corrects the MSRV listed in the READMEs so it matches that defined in each crate's Cargo.toml after Strip buildpack binaries when packaging #445.
  • Adds badges to READMEs that didn't have them, to improve discoverability of the docs (eg towards Improve discoverability of libcnb-test docs on docs.rs #402) and awareness of latest version of each crate. Note: libcnb-cargo does not have a docs link since it's a binary not a library.
  • Syncs the libcnb-cargo usage example output with the latest output used in the repo root README.
  • Switches the docs.rs URLs style from /*/ to /latest/ since the former resolves to an exact version, which if bookmarked (or search engine indexed) will get out of date.
  • Various other small tweaks.

Fixes #274.
Addresses part of #402.
GUS-W-11395978.

* Adds READMEs for the `libcnb-data` and `libcnb-proc-macros` crates,
  since previously they were bundling the repo root README, which was
  confusing when looking at their crates.io listing (#274).
* Corrects the MSRV listed in the READMEs so it matches that defined in
  each crate's `Cargo.toml` after #445.
* Adds badges to READMEs that didn't have them, to improve discoverability
  of the docs (eg towards #402) and awareness of latest version of each crate.
  Note: `libcnb-cargo` does not have a docs link since it's a binary not a library.
* Syncs the `libcnb-cargo` usage example output with the latest output
  used in the repo root README.
* Switches the docs.rs URLs style from `/*/` to `/latest/` since the former
  resolves to an exact version, which if bookmarked (or search engine indexed)
  will get out of date.
* Various other small tweaks.

Fixes #274.
Addresses part of #402.
@edmorley edmorley self-assigned this Jul 7, 2022
@edmorley edmorley marked this pull request as ready for review July 7, 2022 08:40
@edmorley edmorley requested a review from a team as a code owner July 7, 2022 08:40
@edmorley edmorley enabled auto-merge (squash) July 7, 2022 09:48
@edmorley edmorley merged commit 1058761 into main Jul 7, 2022
@edmorley edmorley deleted the edmorley/readmes branch July 7, 2022 09:52
@edmorley edmorley linked an issue Jul 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants