-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change component_name to app_id #2802
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving because the change from component_name
to app_id
looks correct, but take a look to my comment. I believe you missed to do the same path change on the step for retries.
@@ -18,8 +18,8 @@ jobs: | |||
-H "Accept: application/json" \ | |||
-H "Content-Type: application/json" \ | |||
-H "Authorization: Token ${{ secrets.TPS_API_TOKEN_PARAM }}" \ | |||
-d '{"lock": {"sha": "${{ github.sha }}", "component_name": "${{ secrets.TPS_API_APP_ID }}"}}' \ | |||
${{ secrets.TPS_API_URL_PARAM }}/api/ctc` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you removed the path /api/ctc
here. Was that moved to the URL set in the secrets? In that case I believe you need to do the same for retries on line 45 below because it still has that path set.
We were accidentally sending the component name, not app_id on this request, just fixes that in the workflow