Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial buildpack implemention using libcnb.rs #1

Merged
merged 100 commits into from
Aug 1, 2022
Merged

Initial buildpack implemention using libcnb.rs #1

merged 100 commits into from
Aug 1, 2022

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented May 18, 2022 •
edited
Loading

This PR implements the CNB Buildpack Specification and aims to target Go apps written in Go 1.16 or greater with full support for Go Modules. It's written in Rust, and leverages libcnb.rs, similar to other Heroku and Salesforce Functions buildpacks like buildpacks-jvm and buildpacks-nodejs.

More details in the README.

Things left to do that will come in subsequent PRs:

  • Automate building and publishing buildpacks to the buildpack registry
  • Automate inventory.toml updates
  • Automate Go distribution tarball mirroring

GUS: W-11189514

@joshwlewis
Initial libcnb scaffold
0e195e5
@joshwlewis
Add inventory
a2b0dc9
@joshwlewis
Add binary to build inventory
afe394f
@joshwlewis
Update inventory versions
f67c527
@joshwlewis
(De)serialize inventory version as semver
36cc596
@joshwlewis
Sort inventory in reverse order
a81076c
@joshwlewis
Change inventory toml keys
d33aa18
@joshwlewis
Drop old inventory keys
1223621
@joshwlewis
inv.rs refactoring
1443c11
@joshwlewis
Extract and test Version
1212de9
@joshwlewis
Check go.mod for go version
7cb4814
@joshwlewis
Add integration test and version inventory resolution
bac342a
@joshwlewis
Add basic deps layer
0944012
@joshwlewis
Run deps layer
a31c674
@joshwlewis
Add build and target layers
6b4b46a
@joshwlewis
Add rudimentary go builds
c325026
@joshwlewis
Update to a simpler test fixture
19c658c
@joshwlewis
Move Go stdlib into go_dist
5f384fe
@joshwlewis
Setup GOCACHE
3bface3
@joshwlewis
Detect and set process types
143d2ed
@joshwlewis
Install go modules when required
54f9cf4
@joshwlewis
Use go install instead of go build
45d0a16
@joshwlewis
Add compatibility for older go versions
b8f66db
@joshwlewis
Extract launch table creation
31f1d1d
@joshwlewis
Add default web process to Launch
1ad1a7f
@joshwlewis
Update inventory
b36f709
@joshwlewis
Tests and adjustments for version detection
f4e5a72
@joshwlewis
Fixup imports
a0964b9
@joshwlewis
Download, verify, extract go distribution without writing temp files …
7b031e7 
…or reading entirety into memory
@joshwlewis
Clean up new dist handling
d0d5f47
joshwlewis and others added 22 commits July 15, 2022 15:21
@joshwlewis
Update cargo dependencies
afdc732
@joshwlewis
No need to support bionic at this time
0ca3324
@joshwlewis
Use clear-env true to prevent userland env from impacting the build
9e39c5d
@joshwlewis
Drop serialized builder tests
e7255d5
@joshwlewis
Fan out builder tests, but in parallel #[test] directives
0554196
@joshwlewis
Remove panic condition
bf7630c
@joshwlewis @edmorley
Fix documentation typos
a159f15 
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@joshwlewis @edmorley
Use Command shorthands
6d61a13 
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@joshwlewis @edmorley
Use full (not-shorthand) S3 domain
6fa7380 
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@joshwlewis @edmorley
Increase privacy for externally unreachable structs
640d512 
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@joshwlewis
Use .peekable to simplify collection of packages
4e0b4e4
@joshwlewis
Change layers to pub(crate)
680b9c1
@joshwlewis
Drop single-use mods from lib.rs
936dee2
@joshwlewis
Cleanup main.rs imports
3015a45
@joshwlewis
Cleanup cfg naming
6a87e3a
@joshwlewis
Turn on module_name_repititions clippy and fix occurrences
7ae81e5
@joshwlewis
Set build and target layers to be available for later buildpacks
68ed6e1
@joshwlewis
Expire the module cache after n builds
fc60328
@joshwlewis
Use String for layer version, it's more reliable than a float
d37d865
@joshwlewis
Send stderr to the user during go list
2904e41
@edmorley
Update to libcnb-test 0.6.0
becc563
@edmorley
cargo update && cargo upgrade --to-lockfile
f6cd8f8
@edmorley
Copy link
Member

@joshwlewis I've pushed becc563 which updates to libcnb-test 0.6.0 (released today)

@joshwlewis joshwlewis merged commit 0c26bd9 into main Aug 1, 2022
@joshwlewis joshwlewis deleted the initial branch August 1, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwlewis @edmorley