Fix bug from PR#691 where the nodes of a newly created file are lost upon a subsequent load operation #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upon a subsequent load operation
georgehansper
force-pushed
the
fix_691_modified
branch
from
7f106e1
to
2c4f6b8
Compare
ekohl
reviewed
Apr 26, 2023
There was a problem hiding this comment.
In voxpupuli/puppet-augeasproviders_core#49 (comment) there's a verification that this solves the bug showing up in Puppet so 👍 for this.
|
Thanks for confirming this @ekohl |
|
Thanks for this. Any plans for a release that includes it? While we do have a workaround in our code now (voxpupuli/puppet-augeasproviders_core@da34348), it would be great to have the real fix in place. Especially since it can take some time before a new release makes it to all platforms. |
|
I'd like to do a minor release soon |
|
augeas-1.14.1 is now released, with this fix included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #691 introduced a new function to path expressions
modified()This function exposed the value of the internal flag
dirtyon a node.In order for
modifed()to reflect only the changed nodes, some of the logic around thedirtyflag was modified.This caused a bug which appeared after a
saveoperation, where upon a subsequentloadoperation, where the nodes of a newly created file were inadvertently removed.This PR fixes the inadvertent cleanup on the subsequent load operation, if the file has been saved.
Unsaved nodes under
/filesare still cleaned up by the load operation