Fix compilation of PHP due ICU 70

[osrecio]

Fix the installation of older versions of PHP due to the update of ICU 70

Fixed issues: #158

More info: php/php-src#7596

Thanks @nickolasburr for the hint!

[JPry]

How can I test this before it is merged?

[osrecio]

You can test it following next steps:

cd  /opt/homebrew/Library/Taps/henkrehorst/homebrew-php/

git pull origin pull/160/head:fix-php
git checkout fix-php

brew install valet-php@x.x --build-from-source 

x.x can be: 7.0, 7.1, 7.2, 7.3, 7.4, 8.0, 8.1

[JPry]

Thanks @osrecio, I can confirm that the fix works for PHP 7.4, 8.0, and 8.1. But I see issues for these versions:

7.0

brew install --build-from-source valet-php@7.0
==> Downloading https://github.com/henkrehorst/homebrew-php/master/Patches/php70-icu70.patch

curl: (22) The requested URL returned error: 404 
Error: valet-php@7.0: Failed to download resource "valet-php@7.0--patch"
Download failed: https://github.com/henkrehorst/homebrew-php/master/Patches/php70-icu70.patch

7.1

brew install --build-from-source valet-php@7.1
==> Downloading https://github.com/henkrehorst/homebrew-php/master/Patches/php71-icu70.patch

curl: (22) The requested URL returned error: 404 
Error: valet-php@7.1: Failed to download resource "valet-php@7.1--patch"
Download failed: https://github.com/henkrehorst/homebrew-php/master/Patches/php71-icu70.patch

7.2

brew install --build-from-source valet-php@7.2  
==> Downloading https://github.com/henkrehorst/homebrew-php/master/Patches/php71-icu70.patch

curl: (22) The requested URL returned error: 404 
Error: valet-php@7.2: Failed to download resource "valet-php@7.2--patch"
Download failed: https://github.com/henkrehorst/homebrew-php/master/Patches/php71-icu70.patch

7.3

brew install --build-from-source valet-php@7.3      
==> Downloading https://github.com/henkrehorst/homebrew-php/master/Patches/php73-icu70.patch

curl: (22) The requested URL returned error: 404 
Error: valet-php@7.3: Failed to download resource "valet-php@7.3--patch"
Download failed: https://github.com/henkrehorst/homebrew-php/master/Patches/php73-icu70.patch

[osrecio]

Ahh yes,

the problem is those patch files will not exists until the PR will be merged.

you can edit the formula to store the patches in local url for example

to edit formula: brew edit valet-php@7.0

[JPry]

the problem is those patch files will not exists until the PR will be merged.

I had a feeling that was the likely issue, but still figured it was worth flagging 🙂

[osrecio]

@henkrehorst any chance to take a look this PR?

Thanks!

[diazwatson]

After applying these changes I was able to install 7.3 and 7.4 with no issues, thanks @osrecio

[manuelson]

Ey @henkrehorst can you please review this ticket? Thanks!!!