Start implementing semver #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
approved these changes
Aug 26, 2023
| ensure!( | ||
| version.op == semver::Op::Exact && version.minor.is_some() && version.patch.is_some(), | ||
| "artifactory only support pinned dependencies" | ||
| ); |
There was a problem hiding this comment.
It might be nicer to move this validation where the version requirement is added. But I guess this will change soon so it's not a big deal.
There was a problem hiding this comment.
Well, the requirements are valid in the manifest they just can't be used with the artifactory registry impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use the
semvercrate's typesVersionandVersionReqinstead of stringsImplications
Existing version requirements in manifests will result in errors as the default operator is
Caretand onlyExactis supported as of right now.Example:
Will have to be changed to:
The proper evalutation / resolution of requirements will be implemented by the registry (see #12)