Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/moodle] Chart for moodle #485

Merged
merged 13 commits into from
Mar 22, 2017
Merged

[stable/moodle] Chart for moodle #485

merged 13 commits into from
Mar 22, 2017

Conversation

sameersbn
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

Hi @sameersbn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2017
@viglesiasce
Copy link
Contributor

@k8s-bot ok to test

@sameersbn
Copy link
Contributor Author

sameersbn commented Feb 1, 2017 •
edited
Loading

/cc @prydonius @lachie83

@sameersbn sameersbn mentioned this pull request Feb 13, 2017
Closed
@sameersbn sameersbn force-pushed the moodle-chart branch 2 times, most recently from 6b0cdab to 4e6f0d8 Compare February 24, 2017 04:39
@sameersbn
Copy link
Contributor Author

fixed:

  • command to fetch password from secrets volume
  • updated locked mariadb chart version
  • remove mariadb persistent volume storageClass default

@lachie83 lachie83 modified the milestone: Milestone 4 Mar 9, 2017
Sameer Naik added 12 commits March 10, 2017 09:42
lachie83
lachie83 reviewed Mar 15, 2017
View reviewed changes
stable/moodle/.helmignore Outdated
@@ -0,0 +1 @@
.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the standard .helmignore. Did you generate using helm create

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the standard .helmignore you can use:

# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*~
# Various IDEs
.project
.idea/
*.tmproj

@lachie83 lachie83 added code reviewed lgtm Indicates that a PR is ready to be merged. and removed awaiting review labels Mar 15, 2017
@lachie83
Copy link
Contributor

@sameersbn Thanks for the contrib. This LGTM

@lachie83 lachie83 added lgtm Indicates that a PR is ready to be merged. changes needed size/medium and removed lgtm Indicates that a PR is ready to be merged. labels Mar 15, 2017
seanknox
seanknox suggested changes Mar 17, 2017
View reviewed changes
stable/moodle/.helmignore Outdated
@@ -0,0 +1 @@
.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the standard .helmignore you can use:

# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*~
# Various IDEs
.project
.idea/
*.tmproj

@seanknox seanknox added lgtm Indicates that a PR is ready to be merged. and removed changes needed labels Mar 22, 2017
@mgoodness mgoodness merged commit e3127d7 into helm:master Mar 22, 2017
@sameersbn sameersbn deleted the moodle-chart branch March 23, 2017 09:46
yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017
@mgoodness
[stable/moodle] Chart for moodle (helm#485)
0c89cb2 
* adds moodle chart
* lock mariadb chart requirement to 0.5.x series

* explicitly set default `imagePullPolicy` to `IfNotPresent`

* moodle: add alpha and beta storageclass annotation support

* moodle: increase resource name truncation and trim - suffix

* update moodle image to `bitnami/moodle:3.2.1-r1`

* moodle: updated to image `bitnami/moodle:3.2.1-r2`

Contains fix for https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-5340

* moodle: updated to image `bitnami/moodle:3.2.1-r3`

* moodle: updated  requirements.lock

* moodle: fix command to fetch moodle-password from secrets volume

* moodle: remove mariadb persistent volume `storageClass` default

* moodle: regernerated requirements.lock

* Update .helmignore
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lachie83 lachie83 lachie83 left review comments

@seanknox seanknox seanknox approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. size/medium UX reviewed
Projects
None yet
Milestone
Milestone 4
Development

Successfully merging this pull request may close these issues.
6 participants
@sameersbn @k8s-ci-robot @viglesiasce @lachie83 @seanknox @mgoodness