Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[cockroachdb] Document that windows hostpath provisioner is not suppo… #11928

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

jonaseck2
Copy link
Contributor

…rted

Signed-off-by: Jonas Eckerström jonaseck@gmail.com

What this PR does / why we need it:

You can't run cockroachdb in docker for windows kubernetes due to file system issues when using the hostpath provisioner. Works great for linux and MacOs though and the suggested solution for windows is not to use windows... cockroachdb/docs#3184 (comment)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • [x ] Chart Version bumped
  • Variables are documented in the README.md

…rted

Signed-off-by: Jonas Eckerström <jonaseck@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jonaseck2. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Mar 7, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jonaseck2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8b0c277 into helm:master Mar 7, 2019
alvgarvilla pushed a commit to alvgarvilla/charts that referenced this pull request Mar 13, 2019
…rted (helm#11928)

Signed-off-by: Jonas Eckerström <jonaseck@gmail.com>
rmccorm4 pushed a commit to rmccorm4/charts that referenced this pull request Mar 26, 2019
…rted (helm#11928)

Signed-off-by: Jonas Eckerström <jonaseck@gmail.com>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
…rted (helm#11928)

Signed-off-by: Jonas Eckerström <jonaseck@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants