Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone language support for just #6453

Merged
merged 14 commits into from
Apr 14, 2023

Conversation

VuiMuich
Copy link
Contributor

While there was some basic support for just language derived from make this adds it as its own language with its dediceted treesitter.
All the queries are just copied from the tree-sitter-just project.

Let me know if this is missing anything.

languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
runtime/queries/just/highlights.scm Show resolved Hide resolved
runtime/queries/just/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/just/injections.scm Outdated Show resolved Hide resolved
runtime/queries/just/locals.scm Outdated Show resolved Hide resolved
runtime/queries/just/textobjects.scm Show resolved Hide resolved
VuiMuich and others added 3 commits March 29, 2023 10:10
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@VuiMuich
Copy link
Contributor Author

Ok, I get it, straight out copying the queries was a bit short-sighted 😂

I'll look into rewriting the remaining deviations today or tomorrow.
Thanks @the-mikedavis for the detailed pointers and suggestions!

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other queries look good. I have just some minor comments on textobjects and locals

runtime/queries/just/textobjects.scm Show resolved Hide resolved
runtime/queries/just/locals.scm Outdated Show resolved Hide resolved
runtime/queries/just/textobjects.scm Outdated Show resolved Hide resolved
runtime/queries/just/textobjects.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Apr 14, 2023
@pascalkuthe pascalkuthe changed the title [lang] just as its own language Add standalone language support for just #6453 Apr 14, 2023
@pascalkuthe pascalkuthe changed the title Add standalone language support for just #6453 Add standalone language support for just Apr 14, 2023
@pascalkuthe pascalkuthe merged commit 4cdba7c into helix-editor:master Apr 14, 2023
@VuiMuich
Copy link
Contributor Author

Thanks for the merge and especially thanks for the patient review @the-mikedavis!

@VuiMuich VuiMuich deleted the language-just branch April 14, 2023 15:21
kenden added a commit to kenden/just that referenced this pull request May 19, 2023
Helix added support for justfiles in version 20.05 (in this Pull Request: helix-editor/helix#6453)
kenden added a commit to kenden/just that referenced this pull request May 19, 2023
Helix added support for justfiles in version 23.05 (in this Pull Request: helix-editor/helix#6453)
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants