export seed to stdout for Solana CLI usage #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madninja
reviewed
Jan 4, 2023
use serde_json to create string of array of numbers fix comment fix fn doc Use libaray features * Use the fact that an ed25519 keypair is a private/public key in sequence * Use the `json!` macro instead of implementing json conversion ourselves move json formatting to cli layer Seperates concerns better and makes testing in keypair concise fix some comments remove extraneous error message remove informational output s.t. export can be piped to file Fix unused use statement
madninja
force-pushed
the
lthiery/solana-export
branch
from
8a3d988
to
795ce83
Compare
madninja
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
helium-wallet exportretains its behavior, which displays the encrypted seed in JSON encoded in a QR-code.helium-wallet export --format qrexplicitly selects this option.Meanwhile,
helium-wallet export --format seedwill output to stdout the seed in a byte array encoded as a string. This allows the user to put the output intoid.json, for example, and to use it with the Solana CLI.