Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Solana pukeys for ED25519 keys #300

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Show Solana pukeys for ED25519 keys #300

merged 2 commits into from
Dec 20, 2022

Conversation

lthiery
Copy link
Contributor

@lthiery lthiery commented Dec 19, 2022

No description provided.

@lthiery
Copy link
Contributor Author

lthiery commented Dec 19, 2022

A ton of conflicts in the lock so I removed the file and started again. I can do it more systematically if necessary...

@madninja
Copy link
Member

@jwmakesgames I did warn you about not spamming a repo with comments or approvals

madninja
madninja reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@madninja madninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the b64 issue is quite easy and I did this in gateway-rs already too

src/traits/read_write.rs Outdated Show resolved Hide resolved
src/keypair.rs Outdated Show resolved Hide resolved
src/keypair.rs Outdated Show resolved Hide resolved
madninja
madninja reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@madninja madninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

src/keypair.rs Outdated Show resolved Hide resolved
@lthiery lthiery marked this pull request as ready for review December 20, 2022 17:35
madninja
madninja reviewed Dec 20, 2022
View reviewed changes
src/cmd/info.rs Outdated Show resolved Hide resolved
src/keypair.rs Outdated Show resolved Hide resolved
src/keypair.rs Outdated Show resolved Hide resolved
src/traits/read_write.rs Outdated Show resolved Hide resolved
@lthiery lthiery force-pushed the lthiery/solana branch 2 times, most recently from 9515a98 to 25686ac Compare December 20, 2022 18:05
@madninja madninja merged commit 51860b7 into master Dec 20, 2022
@madninja madninja deleted the lthiery/solana branch December 20, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madninja madninja madninja approved these changes

@jwmakesgames jwmakesgames jwmakesgames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lthiery @madninja @jwmakesgames