Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PIC32MM/MX & PIC24 support #1623

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Initial PIC32MM/MX & PIC24 support #1623

merged 2 commits into from
Oct 10, 2022

Conversation

ReimuNotMoe
Copy link
Contributor

Describe the PR
Initial Microchip PIC32MM/MX & PIC24 support. Based on the KHCI implementation.

Only device mode is supported at this moment.

Additional context
Tested on the Microchip PIC32MM0064GPM028.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superb! thank you very much for the ports. Currently, I don't have any pic32mm board to test this out, but can you add the bsp for pic32mm board so that it can be easily tested for other users. If that is too much work, we can merge this as it is and do that later on.

Note: since pic32mm and nxp khci use the same chipidea fs usb, we can merge them into general drivers later on in the future. (just a head up).

@ReimuNotMoe
Copy link
Contributor Author

The test code is a bit complicated for PIC devices. Basically there are 2 factions when it comes to PIC development - some people would just use everything supplied by Microchip (including their huge IDE & build system), and other people (like me) use as many free software components as possible. Currently the test firmware project of the both PIC32MM and PIC24 uses CMake and contains some out-of-tree BSP files, and it would be unwise to include all of them in the TinyUSB code tree (or you think otherwise?). So I suggest you to merge them directly. I can provide a dedicated repo for the testing firmwares if you want.

Thanks.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much for the explanation. I understand that providing out-of-box example is a bit complicated, especially as you said, most people would stick with microchip IDE. We will merge this as working piece of code and will look at the running example later on when having time. Thanks again

@hathach hathach merged commit a95fb36 into hathach:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants