-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIO USB support #1412
PIO USB support #1412
Conversation
run as proof of concept
@hathach can you please back this out... this touches a bunch of the Pico SDK integrations (and does weird stuff like setting the clock unconditionally). Perhaps we dropped the ball on reviewing this, but it needs some more work to not just pull in PIO support when the user doesn't want it. |
We can start a discussion again on the code. Particularly, the user should explicitly opt into "dual" USB, and the existing TinyUSB base INTERFACE libraries should not include it. |
actually, i just added a PR instead #1467 |
Right, I agree that user need to explicitly specify the dual USBs. I am not too familiar with the way pico-sdk wrapper for tinyusb lib/target definition, but I did try to add a separated target/lib for pio_usb, and user indeed need to initialize that in addition to normal tinyusb_device/host.
thanks, I am currently off for a couple of days, will review it next week. |
Yes, it was actually nice and separate, the weirdness we have with keeping things happy when doing raw TinyUSB examples (which includes pico-sdk within it's build) and SDK (which includes TinyUSB within it's build) and pico-examples which uses TinyUSB examples build as a sub-build just needed a little jiggling! |
Describe the PR
Add support for pico-pio-usb, allow TinyUSB can be used with both native usb (rhport0) and pio-usb (rhport1). Currently pio-usb and native usb must be on different mode. For recommendation, native should be device and pio-usb as host, since device has an stricter timing constraint, while in host mode, rp2040 basically control all the timing.
To test this PR
requires sekigon-gonnoc/Pico-PIO-USB#22