Fix video_capture example fails enumeration when 8FPS #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwMaxFrameInterval minus dwMinFrameInterval should be evenly divisible by dwFrameIntervalStep.
hathach
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
If
FRAME_RATEwas changed to 8, enumeration process had been failed.FRAME_RATEis defined followings.tinyusb/examples/device/video_capture/src/usb_descriptors.h
Line 38 in 3b09b82
See also: #1118 (comment)
Additional context
I had confirmed this patch on Raspberry Pi Pico.