Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ep descriptor wMaxPacketSize bitfield due to endian issue #1161

Merged
merged 3 commits into from
Oct 24, 2021

Conversation

hathach
Copy link
Owner

@hathach hathach commented Oct 24, 2021

Describe the PR
Detailed explanation can be found in #1114 . In sum up, there is issue with compiler and bit-field order when compiling with big endian and different bit-order. It is best to just use uint16_t for wMaxPacketSize and use bitmask op. Helper tu_edpt_packet_size() extract the max packet size with endian consideration.

supersede and close #1114

@hathach hathach merged commit 54bcc9f into master Oct 24, 2021
@hathach hathach deleted the rm-ep-size-bitfield branch October 24, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant