New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typehint on Xml parser, parse method #130

Merged

DavidePastore merged 1 commit into hassankhan:develop from yannickroger:fix-typing-parse-xml

Oct 30, 2020

Contributor

yannickroger commented Oct 14, 2020

Hi,
The method parse is always called by using the result of simplexml_load_string which is SimpleXMLElement and not an array.


          Fixed typehint on Xml parser, parse method

290d17d

DavidePastore added this to the Future Release milestone

DavidePastore self-assigned this

DavidePastore added the enhancement label

DavidePastore merged commit 316ddf4 into hassankhan:develop

Collaborator

DavidePastore commented Oct 30, 2020

Hi @yannickroger ! Thanks for this PR! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels