Fixes #115 #118
Merged
Fixes #115 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hassankhan
approved these changes
Feb 1, 2019
|
Thanks for your PR, @filips123! |
|
@filips123 I've also added you as a collaborator on the repository, so you won't have to rely on myself or @DavidePastore. We don't get enough time to give this library the love that it deserves, and I feel you've been really helpful in keeping this project alive. Thanks again for all your hard work 👍 |
|
@hassankhan Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #115.
The problem in #115 is that variable
$configis already initialized in the parameter ofparseString()as a string. The configuration file will then try to re-initialize it and fail it becauseeval()executions can see and modify variables from the real file.This PR adds a separate "isolated" method which only executes string with
eval(). It must use some weird parameter name because we must ensure that is wont be in the config file. I think that$EGsfKPdue7ahnMTy(some random string) would be enough.