-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for change of Data.Text.Array to type synonym (Support text-2.1) #1055
Conversation
In an upcoming version of text, Array will become a type synonym for Data.Array.Byte.ByteArray, which means that importing its constructors will no longer bring the ByteArray constructor into scope.
|
I've added a commit to relax the |
I reported the CI timeout here: |
@phadej : Would it be possible to release this patch now? That would help me testing
But it fails because |
I don't see any urgency. GHC-9.8 will come soon (this month, i.e. September) with plenty of major version bumps, also there's AFAICT, Yes, there are alpha releases so we can test stuff before actual release, but the latest GHC-9.8.1-alpha3 doesn't even have |
Another alternative for testing things before 9.8 is released should be head.hackage. This patch should also be there. Not sure if haskell-ci supports that though |
It does. |
(AFAICT GHC 9.8 will ship with |
That's silly. The most visible breaking change in bytestring-0.12 and text-2.1 are the same one: |
@phadej not me calling the shots on this. |
I opened a GHC issue https://gitlab.haskell.org/ghc/ghc/-/issues/23926 |
@Bodigrim, you say you don't, but you do: haskell/text#532 (comment) |
If GHC developers prefer to stick to an older release for whatever reason, it's entirely up to them. Equally, it's entirely up to me whether to spend my unpaid time on backports and/or get grumpy about unplanned work. |
@phadej: With the GHC 9.8.1 RC1 out, may I renew my request to release this patch please? This would make it so much easier to test New facts are: GHC 9.8 will be released both with |
Due to missing release of haskell/aeson#1055
Thanks! |
https://hackage.haskell.org/package/aeson-2.2.1.0 is on Hackage |
Great thanks! Would be excellent if you could you also release
|
In an upcoming version of text, Array will become a type synonym for Data.Array.Byte.ByteArray, which means that importing its constructors will no longer bring the ByteArray constructor into scope.
This change gives a backwards compatible way to avoid the build failing when that change happens.