Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable egress for server network policy #389

Merged
merged 6 commits into from
Dec 16, 2020

Conversation

corest
Copy link
Contributor

@corest corest commented Sep 18, 2020

There are specific cases when the server pod needs to communicate with some external components.
E.g. when using various auth backends:

  • kubernetes - server needs to talk with k8s api
  • github - server needs to talk with github

@jasonodonnell jasonodonnell self-requested a review October 1, 2020 14:45
@jasonodonnell
Copy link
Contributor

jasonodonnell commented Oct 1, 2020

@corest Thanks for the contribution!

This use case makes sense but I wonder if we need to allow users to pass in whatever configurations they want for their egress.
For example, instead of egress being a boolean, we instead just take whatever YAML the operator wants to add. server.initContainers is a good example of this.

Using this design an operator can add whatever to rules they want for their environment and we don't need a bunch of very specific configurables.

Thoughts?

@corest
Copy link
Contributor Author

corest commented Oct 5, 2020

@jasonodonnell agree
Added test for egress templation

@jasonodonnell jasonodonnell merged commit f8e6aab into hashicorp:master Dec 16, 2020
@tvoran tvoran mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants