Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for StatefulSet updateStrategy #172

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

lawliet89
Copy link
Contributor

If Auto Unseal is configured, it should be safe to allow a rolling update strategy. This should be an option for a less involved upgrade process.

I have been using the "incubator/vault" chart which deploys Vault as a Deployment and I've not had issues performing upgrades.

@lawliet89 lawliet89 changed the title Allow configure StatefulSet updateStrategy Add configuration for StatefulSet updateStrategy Jan 13, 2020
@jasonodonnell
Copy link
Contributor

Hi @lawliet89, thanks for the contribution.

The update strategy is this way to avoid upgrading the primary Vault server before replicas in HA clusters. I think would probably make sense if you aren't running in HA mode, but this isn't helpful for HA clusters. Incubator can get away with rolling updates because it's a single deployment, not a statefulset.

@lawliet89
Copy link
Contributor Author

lawliet89 commented Jan 17, 2020

Could you explain to me how a rolling update for a StatefulSet would differ from a Deployment please? I think it would be nice to have an option (that is not default) to have a "hands-off" upgrade approach. Otherwise, it's quite laborious to upgrade Vault.

Also, the zeroth replica might not always be the leader too.

@jasonodonnell
Copy link
Contributor

@lawliet89 Actually, I was wrong, there wouldn't be a difference between the two. I'm going to merge this as there are use cases for non-HA deployments.

@jasonodonnell jasonodonnell merged commit eccd71b into hashicorp:master Jan 18, 2020
@lawliet89 lawliet89 deleted the updateStrategyType branch January 20, 2020 03:10
@fischerman
Copy link
Contributor

@lawliet89 Beware that this does not free you from recreating the pods if the config file changes

radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants