Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze node/npm version to work around package-lock bug #335

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Jun 15, 2022

@swenson swenson requested a review from a team June 15, 2022 20:47
@calvn
Copy link
Member

calvn commented Jun 15, 2022

Looks like npm install is still failing

@swenson
Copy link
Contributor Author

swenson commented Jun 15, 2022

@calvn I think it is due to semantic-release. Working on it.

@swenson swenson force-pushed the fix-lock branch 2 times, most recently from ee154cd to 807d32a Compare June 15, 2022 21:42
Node 16.14.2 thinks the `package-lock.json` is out of sync when it is
not.

npm/cli#4660
@swenson swenson changed the title Re-sync package.json and package-lock.json Freeze node/npm version to work around package-lock bug Jun 15, 2022
@swenson
Copy link
Contributor Author

swenson commented Jun 15, 2022

Okay, this should be good now. Tests will fail here though for some reason.

@swenson
Copy link
Contributor Author

swenson commented Jun 15, 2022

Thanks!

@swenson swenson merged commit 6ee4dd3 into main Jun 15, 2022
@swenson swenson deleted the fix-lock branch June 15, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants