(feature) Updates starter workflow to use new yaml format for GitHub Actions v2 #942
Conversation
|
|
| - name: filter-to-pr-open-synced | ||
| uses: actions/bin/filter@master | ||
| with: | ||
| args: action 'opened|synchronize' |
There was a problem hiding this comment.
This step is outdated in the YAML syntax. We've added event filtering directly to the YAML. You can achieve this by movig the types up into the on trigger above. In this case:
on:
pull_request:
types: [ opened, synchronize ]However, the default triggers for on: pull_request are actually opened, synchronized, reopened which seem like reasonable defaults here, too, so you might just remove this step and not update the on: pull_request line at all.
There was a problem hiding this comment.
Additionally with the latest release of 0.4.2, you no longer have to run these checks exclusively on PRs. You can just run it on a normal push
|
@booyaa @ethomson @James-Quigley I think this is superseded by #988, right? Shall I close? |
To address this issue: hashicorp/terraform-github-actions#67
Still need to update individual action references, but will do as separate PRs.