resource/aws_eks_node_group: Add capacity_type argument and support multiple instance_types

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_eks_node_group: Add `capacity_type` argument and support multiple `instance_types`

Output from acceptance testing (failure unrelated):

--- PASS: TestAccAWSEksNodeGroup_disappears (1137.64s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Single (1146.91s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1158.65s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1169.90s)
--- PASS: TestAccAWSEksNodeGroup_CapacityType_Spot (1189.79s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1212.94s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1252.51s)
--- FAIL: TestAccAWSEksNodeGroup_AmiType (1273.27s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1314.53s)
--- PASS: TestAccAWSEksNodeGroup_basic (1328.29s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1334.23s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1362.48s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1399.97s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Multiple (1406.37s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1769.34s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1894.86s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2031.79s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (4389.64s)
--- PASS: TestAccAWSEksNodeGroup_Version (5102.97s)
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (5206.07s)

[anGie44]

LGTM 🎉

[ghost]

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[langesven]

does it happen by design that this forces a re-creation of the EKS node group even if I don't set the value at all?
it's setting the capacity_type to the same value that was already being used previously as on_demand was the default, so this should ideally be a no-op I'd assume..

  # module.kubernetes.module.eks.aws_eks_node_group.eks_node_group[0] must be replaced
-/+ resource "aws_eks_node_group" "eks_node_group" {
        ami_type        = "AL2_x86_64"
      ~ arn             = "arn:aws:eks:eu-central-1:1234567890:nodegroup/eks-cluster/eks-cluster/7ab8892c-4b62-72ae-09ac-00c8f8ed2c8f" -> (known after apply)
      + capacity_type   = "ON_DEMAND" # forces replacement
        cluster_name    = "eks-cluster"
        disk_size       = 100

even if I inject the capacity_type into the terraform state and push it it comes back and still wants to replace the node group for no good reason at all :)

[anGie44]

Hi @langesven, thanks for commenting here. Looks like we're tracking a similar issue here #16547 . In the example provided, are you upgrading from 3.18 to 3.19 as well? If the linked issue seems different from your use-case, do you mind creating a new issue with steps to reproduce/configuration details? We're also investigating if this could perhaps be region specific.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!